Separate components into their own packages #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into their own packages
🦋 Changeset detectedLatest commit: a0b2d90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joephela
approved these changes
Dec 4, 2024
avo
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
After discussing the problem with @joephela, we decided it would be best to separate the components into their own packages and leave eslint-config-widen as-is so that other apps won't need to update right away.
This PR creates the following packages corresponding to the exported members of the same name in eslint-config-widen
eslint-config-widen-base
eslint-config-widen-jest
eslint-config-widen-playwright
eslint-config-widen-react
eslint-config-widen-typescript
Tests pass: N/A - no tests included for the original code
Appropriate changes to README are included in PR
The Readme for the base repo and eslint-config-widen could use an update as well, and I can handle that if appropriate